Guest agent support for partitions on SCSI devices #1747
Merged
+306
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevpar
reviewed
May 2, 2023
kevpar
reviewed
May 2, 2023
katiewasnothere
force-pushed
the
kabaldau/scsi_partition_guest
branch
from
b21c405
to
ff8ec27
Compare
anmaxvl
reviewed
May 4, 2023
anmaxvl
approved these changes
May 4, 2023
Merged
katiewasnothere
force-pushed
the
kabaldau/scsi_partition_guest
branch
from
ff8ec27
to
5093a98
Compare
katiewasnothere
force-pushed
the
kabaldau/scsi_partition_guest
branch
from
5093a98
to
6ce96d1
Compare
|
Rebased now that all of Kevin's PRS are in. Waiting for the CI to finish running and then will merge this. |
katiewasnothere
force-pushed
the
kabaldau/scsi_partition_guest
branch
from
6ce96d1
to
b7bc1ea
Compare
There appears to be a linter error. |
* Update `ControllerLunToName` to `GetDevicePath` and take in partition as an additional param * Wait for partition subdirectory to appear for the devices * Update device encryption and verity device names with partition index * Update device encryption and verity device tests * Add new unit tests for `GetDevicePath` Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
katiewasnothere
force-pushed
the
kabaldau/scsi_partition_guest
branch
from
b7bc1ea
to
1a2aca3
Compare
Yeah it was mad about not using a cancel func in a test. Updated. |
anmaxvl
pushed a commit
that referenced
this pull request
Oct 20, 2023
This PR updates our ADO fork to commits in hcsshim up to commit hash [7769a64](7769a64). This includes support for partitioned scsi devices and ensuring filesystem format for lcow scsi devices. Related work items: #1728, #1740, #1741, #1742, #1743, #1744, #1745, #1747, #1748, #1749, #1750, #1752, #1754, #1756, #1757, #1767, #1769, #1771, #1772, #1773, #1779
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on Kevin's recent PRs to clean up our package, refactor our SCSI package, and refactor how we handle layers. You can find those PRs here:
This PR does the following:
ControllerLunToNametoGetDevicePathand take in partition as an additional paramGetDevicePathWhen Kevin's above PRs are in their final state and merged, this PR will be rebased to contain only the last commit containing the changes I outlined above.
To view the contents of this PR, I recommend viewing only the last commit so that github doesn't freak out.